Faster compilation time #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 97.05% 97.04% -0.02%
==========================================
Files 9 9
Lines 1156 1149 -7
==========================================
- Hits 1122 1115 -7
Misses 34 34
Continue to review full report at Codecov.
|
dlfivefifty
approved these changes
Feb 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster Compilation Time (
gaussjacobiandgausshermite)Removing
@.macro makes faster and readable code.related: #47
On current master (tried 3 times):
5.6319661140441895
5.672187805175781
5.6497509479522705
With this PR (tried 3 times):
5.377803087234497
5.1646201610565186
5.101907014846802
On current master (tried 3 times):
5.864084005355835
5.775697946548462
5.807419061660767
With this PR (tried 3 times):
4.963570833206177
4.937578916549683
4.9188759326934814
Fix
AIRY_ROOTSPreviously, there was two definitions of
airy_rootsin the code, and one of them is not correct.I've fixed this.
Other